appDisplay: Only allow ctrl-click for apps that can open new windows

Trust the heuristics in shell_app_can_open_new_window() to get it right
more often than not, and add an appropriate check in activate(). This
makes the behavior consistent with the dash, e.g. we will try to open
a new window (and show the corresponding animation) for apps that don't
have a "New window" item in their dash context menu.

https://bugzilla.gnome.org/show_bug.cgi?id=736329

diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 6640966647c5762093011c2ce8f6d3edccc6d20a..8f5c146df4f88ce945d24d25ef076d21623ad7dc 100644 (file)
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -1687,7 +1687,8 @@ const AppIcon = new Lang.Class({
     activate: function (button) {
         let event = Clutter.get_current_event();
         let modifiers = event ? event.get_state() : 0;
-        let openNewWindow = modifiers & Clutter.ModifierType.CONTROL_MASK &&
+        let openNewWindow = this.app.can_open_new_window () &&
+                            modifiers & Clutter.ModifierType.CONTROL_MASK &&
                             this.app.state == Shell.AppState.RUNNING ||
                             button && button == 2;